dengzhhu653 commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1199532586
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1360,19 +1384,49 @@ public void create_database(final Database db)
}
Deadline.checkTimeout();
}
+ Database db = new Database(createDatabaseRequest.getDatabaseName(),
createDatabaseRequest.getDescription(),
+ createDatabaseRequest.getLocationUri()
,createDatabaseRequest.getParameters());
+ if (createDatabaseRequest.isSetPrivileges()) {
+ db.setPrivileges(createDatabaseRequest.getPrivileges());
+ }
+ if (createDatabaseRequest.isSetOwnerName()) {
+ db.setOwnerName(createDatabaseRequest.getOwnerName());
+ }
+ if (createDatabaseRequest.isSetOwnerType()) {
+ db.setOwnerType(createDatabaseRequest.getOwnerType());
+ }
+ db.setCatalogName(createDatabaseRequest.getCatalogName());
+ if (createDatabaseRequest.isSetCreateTime()) {
Review Comment:
If the create time is not given, I think we can just create a new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
