zhangbutao commented on PR #4341: URL: https://github.com/apache/hive/pull/4341#issuecomment-1556656721
@ayushtkn Nice catch! The conf value ` METASTORE_METADATA_TRANSFORMER_CLASS` is empty which was set by this ticket HIVE-24954, that is say, non acid managed table won't be translated to External table. And my test hive cluster also set this conf ` METASTORE_METADATA_TRANSFORMER_CLASS` to empty by coincidence. You are right. If using the default value, the created iceberg table will always External table type. However, maybe some users like me will disable this conf and set it to empty, so that this can be backward compatibility. I refined the PR to check conf ` METASTORE_METADATA_TRANSFORMER_CLASS` when setting default table location. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
