aturoczy commented on code in PR #4346:
URL: https://github.com/apache/hive/pull/4346#discussion_r1202746366
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/show/ShowPartitionsOperation.java:
##########
@@ -54,12 +55,17 @@ public ShowPartitionsOperation(DDLOperationContext context,
ShowPartitionsDesc d
@Override
public int execute() throws HiveException {
Table tbl = context.getDb().getTable(desc.getTabName());
- if (!tbl.isPartitioned()) {
- throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED,
desc.getTabName());
+ boolean isIcebergTable = isIcebergTable(tbl);
+ if (!(tbl.isPartitioned() || isIcebergTable)) {
+ throw new HiveException(ErrorMsg.TABLE_NOT_PARTITIONED,
desc.getTabName());
Review Comment:
> Haha. We've been developing a tailored storage with some similar concepts
to Iceberg for 10 years. We really like recent changes for Iceberg because it
would give us a chance to move our hacks to standard APIs of storage handlers.
Let me check newly added APIs and propose better generalization.
Yes, Iceberg has a very elegant API and solutions. I like it, also the
concept removes lot of hacks from the hive side as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
