zhangbutao commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1204364886
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -5406,16 +5406,16 @@ protected Table getTableObjectByName(String tabName,
boolean throwException) thr
String[] names = Utilities.getDbTableName(tabName);
final String tableName = names[1];
final String dbName = names[0];
- String metaTable = null;
+ String tableIdentifier = null;
Review Comment:
I finally gave up reusing `TableName.fromString` here as i found some failed
tests.
There are some code snippets use `catalog.dbName.tblName` to identify a
table and `TableName.fromString` can not distinguish between
`catalog.dbName.tblName` and iceberg's `dbName.tblName.metaTable`. I have
no better idea to handle this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
