deniskuzZ commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1205803484
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -498,20 +530,30 @@ public List<CompactionInfo> findReadyToCleanAborts(long
abortedTimeThreshold, in
checkAbortedTimeThreshold && rs.getLong(4) +
abortedTimeThreshold < systemTime;
int numAbortedTxns = rs.getInt(5);
if (numAbortedTxns > abortedThreshold || pastTimeThreshold) {
- CompactionInfo info = new CompactionInfo();
+ AbortTxnRequestInfo info = new AbortTxnRequestInfo();
info.dbname = rs.getString(1);
info.tableName = rs.getString(2);
info.partName = rs.getString(3);
// In this case, this field contains min open write txn ID.
- info.txnId = rs.getLong(6);
- readyToCleanAborts.add(info);
+ info.minOpenWriteTxnId = rs.getLong(6);
Review Comment:
should we move `rs.getLong(6) > 0 ? rs.getLong(6) : Long.MAX_VALUE` logic
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
