scarlin-cloudera opened a new pull request, #4378:
URL: https://github.com/apache/hive/pull/4378
This commit serves as a first step in being able to generate all lateral
views in CBO. Currently, only "inline(array())" udtfs are converted into a CBO
plan.
The lateral view generation has been extracted from Calcite planner and put
into a standalone class with the hope that we can trim down the CalcitePlanner
from a 5000 line class to something more manageable.
In this commit, no "q" test output has been changed. There are some CBO
statements added within tablevalues.q just to ensure that CBO is processing
correctly.
The SemanticAnalyzer changes are small changes to make some utility methods
static so they could be accessed from LateralViewPlan. As future cleanup, these
static classes should be moved outside of SemanticAnalyzer to thin down the
15000+ line file.
The same is true for CalcitePlanner "gen*RexNode*" classes which are also
now static and accessible from LateralViewPlan
A new rule was also created as a precursor to adding CBO support for all
lateral views. The only supported lateral view is the "inline(array())" lateral
view. The special quality of this UDTF is that the lateral view does not need a
lateral view operator. The table is generated through the inline UDTF function
and is joined with the base (input) table fields. The initial implementation
hacked this to work by placing the base table fields within the
"inline(array())" functions so that the top level joined fields are within the
array and no join is needed. This commit places this special case within a rule
to make this manipulation. This will allow a commit in the near future to avoid
special case code in the LateralViewPlan object.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Relevant information in the commit message
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This is part of an umbrella Jira HIVE-27390 which will eventually enable CBO
support for all lateral views
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Current tests are mostly enough due to the fact that this is only a
refactor, but also added "Explain CBO" plans to ensure that the CBO succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
