SourabhBadhya commented on code in PR #4060: URL: https://github.com/apache/hive/pull/4060#discussion_r1213948983
########## beeline/src/java/org/apache/hive/beeline/schematool/tasks/HiveTaskProvider.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hive.beeline.schematool.tasks; + +import org.apache.hadoop.hive.metastore.tools.schematool.HiveSchemaHelper; +import org.apache.hadoop.hive.metastore.tools.schematool.task.SchemaToolTask; +import org.apache.hadoop.hive.metastore.tools.schematool.task.SchemaToolTaskProvider; + +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; +import java.util.function.Supplier; + +public class HiveTaskProvider implements SchemaToolTaskProvider { + + /** + * The map contains {@link Supplier} lambdas, so only the required {@link SchemaToolTask}s are instantiated. + */ + private final Map<String, Supplier<SchemaToolTask>> taskSuppliers = new HashMap<>(); + + @Override + public SchemaToolTask getTask(String command) { + return taskSuppliers.getOrDefault(command, () -> null).get(); + } + + @Override + public Set<String> getSupportedDatabases() { + return new HashSet<>(Collections.singletonList(HiveSchemaHelper.DB_HIVE)); + } + + public HiveTaskProvider(SchemaToolTaskProvider embeddedHmsTaskProvider) { + taskSuppliers.put("initSchema", () -> new HiveContextTask().addChild(new HiveUpdateTask().addChild(embeddedHmsTaskProvider.getTask("info")))); Review Comment: I think strings like "initSchema", "initSchemaTo" etc should be constants. Since the same string is used elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
