veghlaci05 commented on code in PR #4060: URL: https://github.com/apache/hive/pull/4060#discussion_r1214113485
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/SchemaInfo.java: ########## @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore; + +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.metastore.tools.schematool.HiveSchemaHelper; + +import java.io.File; +import java.util.List; + +/** + * Provides information about the HMS or Hive schema + */ +public abstract class SchemaInfo { + + /** + * This must be updated accordingly in case of breaking schema changes. + * For example: adding a new column to an HMS table. + */ + private static final String MIN_HMS_SCHEMA_VERSION = "4.0.0"; Review Comment: No, these are hardcoded values and representing the minimum required versions by the application itself. This means these are strictly bound to the current application code, and can be changed only by developers when they implement something which also changes the schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
