deniskuzZ commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1214256984
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/AbortedTxnCleaner.java:
##########
@@ -118,10 +120,16 @@ private void clean(CompactionInfo info, long
minOpenWriteTxn, boolean metricsEna
abortCleanUsingAcidDir(info, location, minOpenWriteTxn);
} catch (InterruptedException e) {
+ LOG.error("Caught an interrupted exception when cleaning, unable to
complete cleaning of {} due to {}", info,
+ e.getMessage());
+ info.errorMessage = e.getMessage();
+ handleCleanerAttemptFailure(info);
throw e;
} catch (Exception e) {
LOG.error("Caught exception when cleaning, unable to complete cleaning
of {} due to {}", info,
e.getMessage());
+ info.errorMessage = e.getMessage();
+ handleCleanerAttemptFailure(info);
Review Comment:
minor, could we move `info.errorMessage = e.getMessage();` inside of
handleCleanerAttemptFailure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
