SourabhBadhya commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1219115383
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -255,7 +303,9 @@ public CompactionInfo
findNextToCompact(FindNextCompactRequest rqst) throws Meta
StringBuilder sb = new StringBuilder();
sb.append("SELECT \"CQ_ID\", \"CQ_DATABASE\", \"CQ_TABLE\",
\"CQ_PARTITION\", " +
"\"CQ_TYPE\", \"CQ_POOL_NAME\", \"CQ_NUMBER_OF_BUCKETS\",
\"CQ_ORDER_BY\", " +
- "\"CQ_TBLPROPERTIES\" FROM \"COMPACTION_QUEUE\" WHERE \"CQ_STATE\"
= '" + INITIATED_STATE + "' AND ");
+ "\"CQ_TBLPROPERTIES\" FROM \"COMPACTION_QUEUE\" " +
+ "WHERE \"CQ_TYPE\" != " + quoteChar(TxnStore.ABORT_CLEANUP_TYPE) +
Review Comment:
Yes you are right. Removed it. Done.
> is it correct that the type for legacy aborts would be either MINOR or
MAJOR?
Yes legacy aborts have only these 2 types.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -255,7 +303,9 @@ public CompactionInfo
findNextToCompact(FindNextCompactRequest rqst) throws Meta
StringBuilder sb = new StringBuilder();
sb.append("SELECT \"CQ_ID\", \"CQ_DATABASE\", \"CQ_TABLE\",
\"CQ_PARTITION\", " +
"\"CQ_TYPE\", \"CQ_POOL_NAME\", \"CQ_NUMBER_OF_BUCKETS\",
\"CQ_ORDER_BY\", " +
- "\"CQ_TBLPROPERTIES\" FROM \"COMPACTION_QUEUE\" WHERE \"CQ_STATE\"
= '" + INITIATED_STATE + "' AND ");
+ "\"CQ_TBLPROPERTIES\" FROM \"COMPACTION_QUEUE\" " +
+ "WHERE \"CQ_TYPE\" != " + quoteChar(TxnStore.ABORT_CLEANUP_TYPE) +
Review Comment:
Yes you are right. Removed it. Done.
> is it correct that the type for legacy aborts would be either MINOR or
MAJOR?
Yes legacy aborts have only these 2 types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
