saihemanth-cloudera commented on code in PR #4316:
URL: https://github.com/apache/hive/pull/4316#discussion_r1220029434
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2276,6 +2277,9 @@ private void create_table_core(final RawStore ms, final
CreateTableRequest req)
+ " already exists");
}
+ tbl.setDbName(normalizeIdentifier(tbl.getDbName()));
Review Comment:
It tried to implement your suggestion but 29 tests are failing because the
tests are doing assert on the Table to construct a table path or table SD or
something that is expected to be modified in HMS. So I think this change is not
necessary.
Having changes in qfile files that change lineage info (which is anyway
expected) is far better than changing 29 tests to do something else. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
