zhangbutao commented on code in PR #4395:
URL: https://github.com/apache/hive/pull/4395#discussion_r1221954214
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java:
##########
@@ -319,8 +319,9 @@ private boolean
disableSemiJoinOptDueToExternalTable(HiveConf conf, TableScanOpe
if (columnOrigin != null && columnOrigin.op instanceof
TableScanOperator) {
// Join key origin has been traced to a table column. Check if the
table is external.
TableScanOperator joinKeyTs = (TableScanOperator) columnOrigin.op;
- if
(MetaStoreUtils.isExternalTable(joinKeyTs.getConf().getTableMetadata().getTTable()))
{
- LOG.debug("Join key {} is from {} which is an external table.
Disabling semijoin optimization.",
+ if (!StatsUtils.checkCanProvideStats(new
Table(joinKeyTs.getConf().getTableMetadata().getTTable()))) {
+ LOG.debug("Join key {} is from {} which is an external table and
also could not provide statistics. " +
Review Comment:
It is a string placeholder for the table name indeed. Table name value is
here line `L325
`https://github.com/apache/hive/pull/4395/files#diff-1ade8830fed6939060483b84496a26eecab0e7ef64e19265a8e1102e1178fea2L325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
