SourabhBadhya commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1222449544
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -619,15 +666,15 @@ private void setCleanerStart(Connection dbConn,
CompactionInfo info, Long timest
*/
@Override
@RetrySemantics.CannotRetry
- public void markCleaned(CompactionInfo info, boolean isAbortOnly) throws
MetaException {
+ public void markCleaned(CompactionInfo info) throws MetaException {
LOG.debug("Running markCleaned with CompactionInfo: {}", info);
try {
Connection dbConn = null;
PreparedStatement pStmt = null;
ResultSet rs = null;
try {
dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED,
connPoolCompaction);
- if (!isAbortOnly) {
+ if (!info.isAbortedTxnCleanup()) {
Review Comment:
Yes, we no longer generate completed_compactions entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
