deniskuzZ commented on code in PR #4360:
URL: https://github.com/apache/hive/pull/4360#discussion_r1225363400
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java:
##########
@@ -217,48 +218,8 @@ public ParseContext transform(ParseContext pctx) throws
SemanticException {
}
if
(pctx.getConf().getBoolVar(ConfVars.HIVE_SHARED_WORK_REUSE_MAPJOIN_CACHE)) {
- // Try to reuse cache for broadcast side in mapjoin operators that
- // share same input.
- // First we group together all the mapjoin operators that share same
- // reduce sink operator.
- final Multimap<Operator<?>, MapJoinOperator> parentToMapJoinOperators =
- ArrayListMultimap.create();
- for (Set<Operator<?>> workOperators : optimizerCache.getWorkGroups()) {
- for (Operator<?> op : workOperators) {
- if (op instanceof MapJoinOperator) {
- MapJoinOperator mapJoinOp = (MapJoinOperator) op;
- // Only allowed for mapjoin operator
- if (!mapJoinOp.getConf().isBucketMapJoin() &&
- !mapJoinOp.getConf().isDynamicPartitionHashJoin()) {
- parentToMapJoinOperators.put(
- obtainBroadcastInput(mapJoinOp).getParentOperators().get(0),
mapJoinOp);
- }
- }
- }
- }
- // For each group, set the cache key accordingly if there is more than
one operator
- // and input RS operator are equal
- for (Collection<MapJoinOperator> c :
parentToMapJoinOperators.asMap().values()) {
- Map<ReduceSinkOperator, String> rsOpToCacheKey = new HashMap<>();
- for (MapJoinOperator mapJoinOp : c) {
- ReduceSinkOperator rsOp = obtainBroadcastInput(mapJoinOp);
- String cacheKey = null;
- for (Entry<ReduceSinkOperator, String> e: rsOpToCacheKey.entrySet())
{
- if (compareOperator(pctx, rsOp, e.getKey())) {
- cacheKey = e.getValue();
- break;
- }
- }
- if (cacheKey == null) {
- // Either it is the first map join operator or there was no
equivalent RS,
- // hence generate cache key
- cacheKey = MapJoinDesc.generateCacheKey(mapJoinOp.getOperatorId());
- rsOpToCacheKey.put(rsOp, cacheKey);
- }
- // Set in the conf of the map join operator
- mapJoinOp.getConf().setCacheKey(cacheKey);
- }
- }
+ // Try to reuse cache for broadcast side in mapjoin operators that share
the same input.
Review Comment:
could we please move that comment to the method javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
