deniskuzZ commented on code in PR #4372: URL: https://github.com/apache/hive/pull/4372#discussion_r1226814420
########## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ########## @@ -6724,6 +6725,15 @@ public void alterTableBranchOperation(Table table, AlterTableBranchSpec createBr } } + public void alterTableTagOperation(Table table, AlterTableTagSpec createTagSpec) throws HiveException { + try { + HiveStorageHandler storageHandler = createStorageHandler(table.getTTable()); Review Comment: gotcha, we can ignore that in the current PR, but I think that should be refactored to a service that operates on the table object -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org