InvisibleProgrammer commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1235326651
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -473,11 +512,10 @@ private void cleanupMetadataAndUnlock(CommitStatus
commitStatus, String metadata
}
}
- @VisibleForTesting
- void doUnlock(HiveCommitLock lock) {
+ void doUnlock(HiveLock lock) {
Review Comment:
I assume it is to make cleanupMetadataAndUnlock easier to read.
TBH, I can only guess the reason why it shallows the exception: both this
and cleanupMetadataAndUnlock are used in finally blocks. I assume the author
didn't want to add a new exception handling block inside the finally block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
