zhangbutao commented on PR #4418: URL: https://github.com/apache/hive/pull/4418#issuecomment-1600433423
> @zhangbutao I have not used caffiene in the past. So I am not sure how much overhead it is. Just thinking out loud and wondering if adding a cache for just the connectors is an overkill. I do agree that we do have to remove the connectors on alter/drop. We could have a sequence of create/access/drop/re-create and I am not sure if this works today. > @nrg4878 Thanks for sharing your thoughts. caffiene has been used in HIVE-23949, and i think it is more light-weight and stable than other cache. Answer your thought `if adding a cache for just the connectors is an overkill`? I think the value of cache is that we can avoid create connection every time when using data connector. Caching a data connector with connection e.g. jdbc connection is usefull when users operate remote data source frequently. https://github.com/apache/hive/blob/9a8c0f8b7ae7289d1e5eeddf35360806a9faa38a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/AbstractDataConnectorProvider.java#L38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
