ayushtkn commented on code in PR #4417:
URL: https://github.com/apache/hive/pull/4417#discussion_r1237254641
##########
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java:
##########
@@ -489,7 +489,7 @@ private TypeInfo parseType() {
} else if (params.length == 2) {
// New metadata always have two parameters.
precision = Integer.parseInt(params[0]);
- scale = Integer.parseInt(params[1]);
+ scale = Integer.parseInt(params[1].trim());
Review Comment:
@zhangbutao Wasn't the previous approach more safe? If some token expects to
have a space before or after, can we land up in a mess? This seems pretty
generic and I am not sure about the scope, like if trimming all tokens is safe
or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
