deniskuzZ commented on code in PR #4431:
URL: https://github.com/apache/hive/pull/4431#discussion_r1238440952
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -493,20 +501,47 @@ private String getStatsSource() {
}
private Path getStatsPath(Table table) {
- return new Path(table.location() + STATS + table.name() +
table.currentSnapshot().snapshotId());
+ return getStatsPath(table, table.currentSnapshot().snapshotId());
+ }
+
+ private Path getStatsPath(Table table, long snapshotId) {
+ return new Path(table.location() + STATS + table.name() + snapshotId);
}
- private void invalidateStats(Path statsPath) {
+ private void checkAndMergeOrInvalidateStats(ColumnStatistics statsObjNew,
Review Comment:
this method is overloaded. could we split it on invalidate and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
