zabetak commented on code in PR #4430: URL: https://github.com/apache/hive/pull/4430#discussion_r1238667927
########## kafka-handler/src/test/org/apache/hadoop/hive/kafka/KafkaDagCredentialSupplierTest.java: ########## @@ -27,17 +27,35 @@ import org.apache.hadoop.io.Text; import org.apache.hadoop.minikdc.MiniKdc; import org.apache.hadoop.security.token.Token; +import org.apache.kafka.common.config.SslConfigs; +import org.apache.kafka.common.security.auth.SecurityProtocol; +import com.google.common.collect.ImmutableMap; + Review Comment: Fixed in https://github.com/apache/hive/pull/4430/commits/c3b74d7254d28d8c75f811bbdbb94f11b40e4e6b. Interestingly, we have no policy, checks, whatsoever on what should be the order of imports in Hive so we end-up with a mixed style with a bit of everything :) It appears that I was using the import style from another Apache project; now I simply switched to IntelliJ's default cause it matched better the current style in this class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
