simhadri-g commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1239536832
##########
iceberg/patched-iceberg-core/pom.xml:
##########
@@ -76,6 +76,8 @@
<outputDirectory>${project.build.directory}/classes</outputDirectory>
<excludes>
**/HadoopInputFile.class
+ **/TableProperties.class
+ **/ConfigProperties.class
Review Comment:
Small query here:
> But, as 1.3.0 dependency contains those changes, with upgrading Iceberg
dependency to 1.3.0, they could be removed
(https://github.com/apache/hive/commit/ddba7deeb42ba8974e1cd49be96052da3ea259f4).
Since these files are already in iceberg 1.3, shouldn’t we remove these two
lines in the pom.xml ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
