difin commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1239963698
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLUtils.java:
##########
@@ -227,4 +229,17 @@ public static void
validateTableIsIceberg(org.apache.hadoop.hive.ql.metadata.Tab
table.getFullTableName(), tableType));
}
}
+
+ public static boolean isIcebergTable(Table table) {
+ return Optional.ofNullable(table.getStorageHandler())
Review Comment:
We can't because table parameter `table_type` gets put into the table only
in `HiveIcebergMetaHook.preCreateTable` which is called from Metastore client
```
HiveMetaHook hook = getHook(tbl);
if (hook != null) {
hook.preCreateTable(tbl);
}
```
Since we wanted to move the code that puts
`StatsSetupConst.DO_NOT_UPDATE_STATS `into envContext on the caller side, the
`table_type`parameter is always absent at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
