aturoczy commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1241971946
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -915,6 +916,10 @@ private void setCommonJobConf(JobConf jobConf) {
jobConf.set("tez.mrreader.config.update.properties",
"hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids");
}
+ public StorageHandlerTypes getStorageHandlerType() {
Review Comment:
Even it is an instance, the getType mainly used in several languages to
identify the instance oh the current type, and I think it is already overused
across the industry. getHandlerType could be also ok or the long name is ok to
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
