deniskuzZ commented on code in PR #4447:
URL: https://github.com/apache/hive/pull/4447#discussion_r1243603873


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -855,11 +839,15 @@ private void open() throws MetaException {
                   + "Continuing without it.", e);
             }
           }
+        } catch (TTransportException e) {
+          tte = e;
+          String errMsg = String.format("Failed to connect to metastore with 
uri (%s) " +
+              "transport mode: %s in attempt %d ", store, transportMode, 
attempt);
+          LOG.warn(errMsg);
+          LOG.debug(errMsg, e);
         } catch (MetaException e) {
-          recentME = e;
-          String errMsg = "Failed to connect to metastore with URI (" + store
-              + ") transport mode:" + transportMode + " in attempt " + attempt;
-          LOG.error(errMsg, e);
+          throw new MetaException("Could not connect to meta store by 
MetaException: "

Review Comment:
   simply "Failed to connect to metastore: ". also move it in constants



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to