deniskuzZ commented on PR #4415: URL: https://github.com/apache/hive/pull/4415#issuecomment-1609438968
> > @maswin could you please check if the below failure is unrelated: http://ci.hive.apache.org/job/hive-precommit/job/PR-4415/3/testReport/junit/org.apache.hadoop.hive.cli/TestMiniTezCliDriver/Testing___split_15___PostProcess___testCliDriver_vector_non_string_partition_/ > > The test failure was related to the fix. > > In VectorizedParquetRecordReader, partition columns were added every time the next() is called - > > https://github.com/apache/hive/blob/f78ca5df80c0bcb566f0915cda65112268df492c/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java#L406 > > But in VectorizedOrcRecordReader, partition columns are set once and reused on every next() call - > > https://github.com/apache/hive/blob/7c83f6babc1a95e7fc26aeaa779d35ce7c91d1c0/ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java#L130 > > So when I did a reset it was not setting back the partition column. Fixed it. Partition and virtual columns will not be reset. The test passed in my local. Will wait for the full test suite to finish. should we have the same optimization in VectorizedParquetRecordReader? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
