InvisibleProgrammer commented on code in PR #4291: URL: https://github.com/apache/hive/pull/4291#discussion_r1243864151
########## iceberg/patched-iceberg-core/src/main/java/org/apache/iceberg/SerializableTable.java: ########## @@ -1,420 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -package org.apache.iceberg; - -import java.io.Serializable; -import java.util.List; -import java.util.Map; -import org.apache.hadoop.conf.Configuration; -import org.apache.iceberg.encryption.EncryptionManager; -import org.apache.iceberg.hadoop.HadoopConfigurable; -import org.apache.iceberg.io.FileIO; -import org.apache.iceberg.io.LocationProvider; -import org.apache.iceberg.relocated.com.google.common.collect.Maps; -import org.apache.iceberg.util.SerializableMap; -import org.apache.iceberg.util.SerializableSupplier; - -/** - * A read-only serializable table that can be sent to other nodes in a cluster. - * - * <p>An instance of this class represents an immutable serializable copy of a table state and will - * not reflect any subsequent changed made to the original table. - * - * <p>While this class captures the metadata file location that can be used to load the complete - * table metadata, it directly persists the current schema, spec, sort order, table properties to - * avoid reading the metadata file from other nodes for frequently needed metadata. - * - * <p>The implementation assumes the passed instances of {@link FileIO}, {@link EncryptionManager}, - * {@link LocationProvider} are serializable. If you are serializing the table using a custom - * serialization framework like Kryo, those instances of {@link FileIO}, {@link EncryptionManager}, - * {@link LocationProvider} must be supported by that particular serialization framework. - * - * <p><em>Note:</em> loading the complete metadata from a large number of nodes can overwhelm the - * storage. - */ -public class SerializableTable implements Table, Serializable { - - private final String name; - private final String location; - private final String metadataFileLocation; - private final Map<String, String> properties; - private final String schemaAsJson; - private final int defaultSpecId; - private final Map<Integer, String> specAsJsonMap; - private final String sortOrderAsJson; - private final FileIO io; - private final EncryptionManager encryption; - private final LocationProvider locationProvider; - private final Map<String, SnapshotRef> refs; - - private transient volatile Table lazyTable = null; - private transient volatile Schema lazySchema = null; - private transient volatile Map<Integer, PartitionSpec> lazySpecs = null; - private transient volatile SortOrder lazySortOrder = null; - - protected SerializableTable(Table table) { - this.name = table.name(); - this.location = table.location(); - this.metadataFileLocation = metadataFileLocation(table); - this.properties = SerializableMap.copyOf(table.properties()); - this.schemaAsJson = SchemaParser.toJson(table.schema()); - this.defaultSpecId = table.spec().specId(); - this.specAsJsonMap = Maps.newHashMap(); - Map<Integer, PartitionSpec> specs = table.specs(); - specs.forEach((specId, spec) -> specAsJsonMap.put(specId, PartitionSpecParser.toJson(spec))); - this.sortOrderAsJson = SortOrderParser.toJson(table.sortOrder()); - this.io = fileIO(table); - this.encryption = table.encryption(); - this.locationProvider = table.locationProvider(); - this.refs = SerializableMap.copyOf(table.refs()); - } - - /** - * Creates a read-only serializable table that can be sent to other nodes in a cluster. - * - * @param table the original table to copy the state from - * @return a read-only serializable table reflecting the current state of the original table - */ - public static Table copyOf(Table table) { - if (table instanceof BaseMetadataTable) { - return new SerializableMetadataTable((BaseMetadataTable) table); - } else { - return new SerializableTable(table); - } - } - - private String metadataFileLocation(Table table) { - if (table instanceof HasTableOperations) { - TableOperations ops = ((HasTableOperations) table).operations(); - return ops.current().metadataFileLocation(); - } else { - return null; - } - } - - private FileIO fileIO(Table table) { - if (table.io() instanceof HadoopConfigurable) { - ((HadoopConfigurable) table.io()).serializeConfWith(SerializableConfSupplier::new); - } - - return table.io(); - } - - private Table lazyTable() { - if (lazyTable == null) { - synchronized (this) { - if (lazyTable == null) { - if (metadataFileLocation == null) { - throw new UnsupportedOperationException( - "Cannot load metadata: metadata file location is null"); - } - - TableOperations ops = - new StaticTableOperations(metadataFileLocation, io, locationProvider); - this.lazyTable = newTable(ops, name); - } - } - } - - return lazyTable; - } - - protected Table newTable(TableOperations ops, String tableName) { - return new BaseTable(ops, tableName); - } - - @Override - public String name() { - return name; - } - - @Override - public String location() { - return location; - } - - @Override - public Map<String, String> properties() { - return properties; - } - - @Override - public Schema schema() { - if (lazySchema == null) { - synchronized (this) { - if (lazySchema == null && lazyTable == null) { - // prefer parsing JSON as opposed to loading the metadata - this.lazySchema = SchemaParser.fromJson(schemaAsJson); - } else if (lazySchema == null) { - this.lazySchema = lazyTable.schema(); - } - } - } - - return lazySchema; - } - - @Override - public Map<Integer, Schema> schemas() { - return lazyTable().schemas(); - } - - @Override - public PartitionSpec spec() { - return specs().get(defaultSpecId); - } - - @Override - public Map<Integer, PartitionSpec> specs() { - if (lazySpecs == null) { - synchronized (this) { - if (lazySpecs == null && lazyTable == null) { - // prefer parsing JSON as opposed to loading the metadata - Map<Integer, PartitionSpec> specs = Maps.newHashMapWithExpectedSize(specAsJsonMap.size()); - specAsJsonMap.forEach( - (specId, specAsJson) -> { - specs.put(specId, PartitionSpecParser.fromJson(schema(), specAsJson)); - }); - this.lazySpecs = specs; - } else if (lazySpecs == null) { - this.lazySpecs = lazyTable.specs(); - } - } - } - - return lazySpecs; - } - - @Override - public SortOrder sortOrder() { - if (lazySortOrder == null) { - synchronized (this) { - if (lazySortOrder == null && lazyTable == null) { - // prefer parsing JSON as opposed to loading the metadata - this.lazySortOrder = SortOrderParser.fromJson(schema(), sortOrderAsJson); - } else if (lazySortOrder == null) { - this.lazySortOrder = lazyTable.sortOrder(); - } - } - } - - return lazySortOrder; - } - - @Override - public Map<Integer, SortOrder> sortOrders() { - return lazyTable().sortOrders(); - } - - @Override - public FileIO io() { - return io; - } - - @Override - public EncryptionManager encryption() { - return encryption; - } - - @Override - public LocationProvider locationProvider() { - return locationProvider; - } - - @Override - public List<StatisticsFile> statisticsFiles() { - return lazyTable().statisticsFiles(); - } - - @Override - public Map<String, SnapshotRef> refs() { - return refs; - } - - @Override - public void refresh() { - throw new UnsupportedOperationException(errorMsg("refresh")); - } - - @Override - public TableScan newScan() { - return lazyTable().newScan(); - } - - public IncrementalAppendScan newIncrementalAppendScan() { Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
