kasakrisz commented on code in PR #4440:
URL: https://github.com/apache/hive/pull/4440#discussion_r1247713061
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -428,10 +428,11 @@ public boolean
setColStatistics(org.apache.hadoop.hive.ql.metadata.Table hmsTabl
PuffinCompressionCodec.NONE,
ImmutableMap.of()));
writer.finish();
+ return true;
} catch (IOException e) {
LOG.error(String.valueOf(e));
+ return false;
Review Comment:
In general, an API should throw a checked exception to report errors and let
the client side decide how to handle it. An exception object can hold the
details of the error and it is easy to extend in the future. Returning a
boolean doesn't hold any information about the error and it is hard to extend
without API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
