aturoczy commented on code in PR #4448:
URL: https://github.com/apache/hive/pull/4448#discussion_r1248056105
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java:
##########
@@ -108,7 +110,10 @@ public final void onEvent(PreEventContext preEventContext)
}
} catch (Exception e) {
LOG.error("HiveMetaStoreAuthorizer.onEvent(): failed", e);
- throw new MetaException(e.getMessage());
+ MetaException me = new MetaException(e.getMessage());
+ // Init cause for testing check.
+ me.initCause(e);
Review Comment:
Should not be better extend the MetaException? As I remember it can receive
an object already. It is just style. I personally do not like the initCause :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
