okumin commented on PR #4444: URL: https://github.com/apache/hive/pull/4444#issuecomment-1615922959
I'm checking the `HiveMetaStoreClient` family and I found it is not trivial. `HiveMetaStoreClient`, `HiveMetaStoreClientWithLocalCache`, and `SessionHiveMetaStoreClient` are tightly coupled by dynamic dispatching like below. It means they depend on each other in a bi-directional manner, and we can simply replace the dependencies with compositions. - https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java#L167C18-L175 - https://github.com/apache/hive/blob/rel/release-4.0.0-alpha-2/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java#L1430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
