simhadri-g commented on code in PR #4431:
URL: https://github.com/apache/hive/pull/4431#discussion_r1259289961
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -266,7 +267,7 @@ default boolean canProvideBasicStatistics() {
* @return boolean
*/
default boolean setColStatistics(org.apache.hadoop.hive.ql.metadata.Table
table,
- List<ColumnStatistics> colStats) {
+ List<ColumnStatistics> colStats, ColumnStatsDesc columnStatisticsDesc) {
Review Comment:
The mergeColStats from the MetaStoreServerUtils is a void method.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java#L795
Inorder to return (Column Name -> Merge result ) we will have to modify the
MetaStoreServerUtils.mergeColStats to return the result for each column or move
the set column stats accurate to MetaStoreServerUtils.mergeColStats method.
Since this would require a lot of changes, can we address that in a
different jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
