deniskuzZ commented on code in PR #4441:
URL: https://github.com/apache/hive/pull/4441#discussion_r1263664430
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -737,6 +732,45 @@ public void
executeOperation(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
}
}
+ private static void expireSnapshot(Table icebergTable,
AlterTableExecuteSpec.ExpireSnapshotsSpec expireSnapshotsSpec,
Review Comment:
can we pass numThreads instead of deleteExecutorService, so that create and
shutdown have a clear visibility
````
try {
if (numThreads > 0) {
deleteExecutorService =
getDeleteExecutorService(hmsTable.getCompleteName(), numThreads);
}
....
} finally {
if (deleteExecutorService != null) {
deleteExecutorService.shutdown();
}
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
