okumin commented on code in PR #4511:
URL: https://github.com/apache/hive/pull/4511#discussion_r1274884229
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -1819,6 +1820,10 @@ public static enum ConfVars {
HIVE_STRICT_CHECKS_BUCKETING("hive.strict.checks.bucketing", true,
"Enabling strict bucketing checks disallows the following:\n" +
" Load into bucketed tables."),
+
HIVE_STRICT_CHECKS_OFFSET_NO_ORDERBY("hive.strict.checks.offset.no.orderby",
false,
+ "Enabling strict offset checks disallows the following:\n" +
+ " OFFSET without ORDER BY.\n" +
+ "OFFSET is mostly meaningless when a result set doesn't have a total
order."),
Review Comment:
I personally agree with the idea as long as the incompatibility is
introduced to the new major version. In my experience providing a managed Hive
service, the usage of OFFSET without ORDER BY is not so high, and the ratio of
mistakes in the small number of use cases is high. Warning is a more
conservative approach, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
