pkumarsinha commented on code in PR #4501:
URL: https://github.com/apache/hive/pull/4501#discussion_r1277695523
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3021,6 +3021,13 @@ public static enum ConfVars {
HIVE_ZOOKEEPER_KILLQUERY_NAMESPACE("hive.zookeeper.killquery.namespace",
"killQueries",
"When kill query coordination is enabled, uses this namespace for
registering queries to kill with zookeeper"),
+ HIVE_GETPARTITIONS_MAX_RETRIES("hive.getpartitions.max.retries", 5,
Review Comment:
Sorry, missed this one.
Use similar naming convention as what is used for msck repair one.
Something like
HIVE_GETPARTITIONS_BATCH_MAX_RETRIES("hive.getpartitions.batch.max.retries".......
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -4162,6 +4164,50 @@ public Set<Partition> getAllPartitionsOf(Table tbl)
throws HiveException {
return parts;
}
+ /**
+ * Get all the partitions. Do it in batches if batchSize is more than 0 else
get it in one call.
+ * @param tbl table for which partitions are needed
+ * @return list of partition objects
+ */
+ public Set<Partition> getAllPartitionsOf(Table tbl) throws HiveException {
+ int defaultDecayingFactor = 2;
Review Comment:
Should have been a const defined at class level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
