amanraj2520 commented on PR #4450: URL: https://github.com/apache/hive/pull/4450#issuecomment-1656590977
> @amanraj2520 > > 1. Noticed several partial cherry-picks. Can you add details of trade-offs, what is skipped in cherry-picks and why is it not impacting overall functionality? > 2. Why there are custom test output fixes? Share justification for the same. > 3. Re-generate thrift files instead of cherry-picking those changes to ensure it is truly compatible with new thrift version. > 4. Update the title, description to list all the JIRA IDs involved in this backport. 1. I will add them. 2. There are changes because the column size has changed. Because of a new column of write_id. But will add justifaction for some of them. 3. This is already done. 4. Sure will do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
