ayushtkn commented on code in PR #4408: URL: https://github.com/apache/hive/pull/4408#discussion_r1281898743
########## data/conf/hive-site-old.xml: ########## @@ -80,14 +80,6 @@ <description></description> </property> -<property> - <name>hive.metastore.metadb.dir</name> Review Comment: @zhangbutao I tried it and the output ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 05:02 min [INFO] Finished at: 2023-08-02T18:43:53+05:30 [INFO] ------------------------------------------------------------------------ ayushsaxena@ayushsaxena-MBP16 hive % grep -rnw . -e "hive.metastore.metadb.dir" grep: ./patchprocess/.gpg/S.gpg-agent.extra: Operation not supported on socket grep: ./patchprocess/.gpg/S.gpg-agent.ssh: Operation not supported on socket grep: ./patchprocess/.gpg/S.gpg-agent: Operation not supported on socket grep: ./patchprocess/.gpg/S.gpg-agent.browser: Operation not supported on socket ./spark-client/target/testconf/rlist/hive-site.xml:122: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/hive-site.xml:128: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/iceberg/hive-site.xml:119: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/llap/hive-site.xml:138: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/spark/standalone/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/spark/yarn-cluster/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./spark-client/target/testconf/spark/local/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/rlist/hive-site.xml:99: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/hive-site.xml:105: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/perf-reg/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/perf-reg/spark/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/tez/hive-site.xml:109: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/llap/hive-site.xml:115: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/spark/standalone/hive-site.xml:85: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/spark/local/hive-site.xml:85: <name>hive.metastore.metadb.dir</name> ./hcatalog/streaming/target/testconf/spark/yarn-client/hive-site.xml:85: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/rlist/hive-site.xml:122: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/hive-site.xml:128: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/llap/hive-site.xml:138: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/spark/standalone/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/spark/yarn-cluster/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./iceberg-catalog/target/testconf/spark/local/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/rlist/hive-site.xml:122: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/hive-site.xml:128: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/iceberg/hive-site.xml:119: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/llap/hive-site.xml:138: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/spark/standalone/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/spark/yarn-cluster/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./kryo-registrator/target/testconf/spark/local/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/rlist/hive-site.xml:122: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/hive-site.xml:128: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/iceberg/hive-site.xml:119: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/llap/hive-site.xml:138: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/spark/standalone/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/spark/yarn-cluster/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./shims/scheduler/target/testconf/spark/local/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/rlist/hive-site.xml:122: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/hive-site.xml:128: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/tez/hive-site.xml:114: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/hive-site-old.xml:84: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/llap/hive-site.xml:138: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/spark/standalone/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/spark/yarn-cluster/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ./iceberg-handler/target/testconf/spark/local/hive-site.xml:90: <name>hive.metastore.metadb.dir</name> ayushsaxena@ayushsaxena-MBP16 hive % git log -3 commit 437c61100d5b8194f958b5beb5be81be78ad41d4 (HEAD -> HIVE-27431) Author: zhangbutao <[email protected]> Date: Thu Jun 22 15:32:54 2023 +0800 Address review commit a4b7ccc44b21af262fc771f4ab81535fb78b7741 Author: zhangbutao <[email protected]> Date: Mon Jun 12 19:24:29 2023 +0800 HIVE-27431: Clean invalid properties in test moduel ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
