InvisibleProgrammer commented on code in PR #4497:
URL: https://github.com/apache/hive/pull/4497#discussion_r1285919315


##########
itests/hcatalog-unit/pom.xml:
##########
@@ -89,7 +89,7 @@
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-standalone-metastore-server</artifactId>
-      <scope>test</scope>
+      <classifier>tests</classifier>

Review Comment:
   I think it is because they have the same artifact id. 
   The thing that classifier does is just appends the tests string to the 
artifact so that having the same artifact id won't cause any trouble. 
   
   The question that I'm interesting in is why the scope tag is removed? Do we 
need that itests/hcatalog module outside of the test scope? 
   
   Some details about their meaning: https://maven.apache.org/pom.html
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to