deniskuzZ commented on code in PR #4575:
URL: https://github.com/apache/hive/pull/4575#discussion_r1294255828
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergV2.java:
##########
@@ -646,6 +652,33 @@ public void testDMLFailsForCopyOnMergeDeleteMode() {
shell.executeStatement("select count(*) from customers");
}
+ @Test
+ public void testConcurrent2Updates() {
+ Assume.assumeTrue(fileFormat == FileFormat.PARQUET && isVectorized &&
+ testTableType == TestTables.TestTableType.HIVE_CATALOG);
+
+ testTables.createTable(shell, "customers",
HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
+ PartitionSpec.unpartitioned(), fileFormat,
HiveIcebergStorageHandlerTestUtils.OTHER_CUSTOMER_RECORDS_2, 2);
+ String sql = "UPDATE customers SET last_name='Changed' WHERE customer_id=3
or first_name='Joanna'";
+ try {
+ Tasks.range(2)
+ .executeWith(Executors.newFixedThreadPool(2))
+ .run(i -> {
+ init(shell, testTables, temp, executionEngine);
+ HiveConf.setBoolVar(shell.getHiveConf(),
HiveConf.ConfVars.HIVE_VECTORIZATION_ENABLED, isVectorized);
+ HiveConf.setVar(shell.getHiveConf(),
HiveConf.ConfVars.HIVEFETCHTASKCONVERSION, "none");
+ shell.executeStatement(sql);
+ shell.closeSession();
+ });
+ } catch (Throwable ex) {
+ Throwable cause = Throwables.getRootCause(ex);
+ Assert.assertTrue(cause instanceof ValidationException);
+ Assert.assertTrue(cause.getMessage().startsWith("Found new conflicting
delete files"));
+ }
+ List<Object[]> res = shell.executeStatement("SELECT * FROM customers WHERE
last_name='Changed'");
+ Assert.assertEquals(5, res.size());
+ }
Review Comment:
work fine on local machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
