rkirtir commented on code in PR #4497:
URL: https://github.com/apache/hive/pull/4497#discussion_r1298130916
##########
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java:
##########
@@ -1584,69 +1510,39 @@ public void sqlInsertPartition() throws Exception {
event = rsp.getEvents().get(12);
assertEquals(firstEventId + 13, event.getEventId());
- assertEquals(EventType.ADD_PARTITION.toString(), event.getEventType());
+ assertEquals(EventType.INSERT.toString(), event.getEventType());
event = rsp.getEvents().get(13);
assertEquals(firstEventId + 14, event.getEventId());
- assertEquals(EventType.INSERT.toString(), event.getEventType());
- // Parse the message field
- verifyInsert(event, null, tblName);
+ assertEquals(EventType.ALTER_PARTITION.toString(), event.getEventType());
event = rsp.getEvents().get(17);
assertEquals(firstEventId + 18, event.getEventId());
- assertEquals(EventType.INSERT.toString(), event.getEventType());
- // Parse the message field
- verifyInsert(event, null, tblName);
+ assertEquals(EventType.ALTER_PARTITION.toString(), event.getEventType());
event = rsp.getEvents().get(21);
assertEquals(firstEventId + 22, event.getEventId());
- assertEquals(EventType.ADD_PARTITION.toString(), event.getEventType());
+ assertEquals(EventType.UPDATE_PARTITION_COLUMN_STAT.toString(),
event.getEventType());
event = rsp.getEvents().get(24);
assertEquals(firstEventId + 25, event.getEventId());
- assertEquals(EventType.DROP_PARTITION.toString(), event.getEventType());
+ assertEquals(EventType.ALTER_PARTITION.toString(), event.getEventType());
event = rsp.getEvents().get(25);
assertEquals(firstEventId + 26, event.getEventId());
- assertEquals(EventType.ADD_PARTITION.toString(), event.getEventType());
+ assertEquals(EventType.UPDATE_PARTITION_COLUMN_STAT.toString(),
event.getEventType());
event = rsp.getEvents().get(26);
assertEquals(firstEventId + 27, event.getEventId());
- assertEquals(EventType.ALTER_PARTITION.toString(), event.getEventType());
- assertTrue(event.getMessage().matches(".*\"ds\":\"todaytwo\".*"));
+ assertEquals(EventType.INSERT.toString(), event.getEventType());
// Test fromEventId different from the very first
- testEventCounts(defaultDbName, event.getEventId(), null, null, 4);
+ testEventCounts(defaultDbName, event.getEventId(), null, null, 2);
event = rsp.getEvents().get(28);
assertEquals(firstEventId + 29, event.getEventId());
- assertEquals(EventType.INSERT.toString(), event.getEventType());
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]