rtrivedi12 commented on code in PR #4617: URL: https://github.com/apache/hive/pull/4617#discussion_r1299958687
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/function/AbstractFunctionAnalyzer.java: ########## @@ -70,7 +71,7 @@ protected void addEntities(String functionName, String className, boolean isTemp } } if (database != null) { - outputs.add(new WriteEntity(database, WriteEntity.WriteType.DDL_NO_LOCK)); + inputs.add(new ReadEntity(database)); Review Comment: Don't we need this change for Create Function? I and Naveen were discussing this change the other day and thought that the Read privilege on DB should be good for Create function too. Please share your thoughts as I might be missing the complete picture of UDF association with DB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org