abstractdog commented on code in PR #4609:
URL: https://github.com/apache/hive/pull/4609#discussion_r1301257975
##########
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java:
##########
@@ -542,7 +542,7 @@ private Object evaluate(Type type, Object value) {
}
return value;
case TIMESTAMP_TYPE:
- return Timestamp.valueOf((String) value);
+ return
org.apache.hadoop.hive.common.type.Timestamp.valueOf((String)value);
Review Comment:
not necessarily better, we had an internal discussion about this, I'll
update jira but TLDR: we might want to stick to java.sql.Timestamp to remain
inline with JDBC spec (e.g. ResultSet.getTimestamp), in this case I'll have to
close this draft PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
