SourabhBadhya commented on code in PR #4520:
URL: https://github.com/apache/hive/pull/4520#discussion_r1304515200


##########
ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java:
##########
@@ -168,14 +178,24 @@ public List<Task<?>> getTasks(HiveConf conf, Object 
objCtx) {
           int dpLbLevel = numDPCols + lbLevel;
 
           generateActualTasks(conf, resTsks, trgtSize, avgConditionSize, 
mvTask, mrTask,
-              mrAndMvTask, dirPath, inpFs, ctx, work, dpLbLevel);
+              mrAndMvTask, dirPath, inpFs, ctx, work, dpLbLevel, 
manifestFilePresent);
         } else { // no dynamic partitions
           if(lbLevel == 0) {
             // static partition without list bucketing
-            long totalSz = getMergeSize(inpFs, dirPath, avgConditionSize);
-            Utilities.FILE_OP_LOGGER.debug("merge resolve simple case - 
totalSz " + totalSz + " from " + dirPath);
+            List<FileStatus> manifestFilePaths = new ArrayList<>();
+            long totalSz;
+            if (manifestFilePresent) {
+              manifestFilePaths = getManifestFilePaths(conf, dirPath);
+              totalSz = getMergeSize(manifestFilePaths, avgConditionSize);
+            } else {
+              totalSz = getMergeSize(inpFs, dirPath, avgConditionSize);
+              Utilities.FILE_OP_LOGGER.debug("merge resolve simple case - 
totalSz " + totalSz + " from " + dirPath);

Review Comment:
   Renamed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to