scarlin-cloudera commented on code in PR #4442:
URL: https://github.com/apache/hive/pull/4442#discussion_r1306302306
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -1024,30 +1022,8 @@ boolean isCBOExecuted() {
@Override
boolean isCBOSupportedLateralView(ASTNode lateralView) {
- // Lateral view AST has the following shape:
- // ^(TOK_LATERAL_VIEW
- // ^(TOK_SELECT ^(TOK_SELEXPR ^(TOK_FUNCTION Identifier params)
identifier* tableAlias)))
- if (lateralView.getToken().getType() == HiveParser.TOK_LATERAL_VIEW_OUTER)
{
- // LATERAL VIEW OUTER not supported in CBO
- return false;
- }
- // Only INLINE followed by ARRAY supported in CBO
- ASTNode lvFunc = (ASTNode) lateralView.getChild(0).getChild(0).getChild(0);
- String lvFuncName = lvFunc.getChild(0).getText();
- if (lvFuncName.compareToIgnoreCase(
- GenericUDTFInline.class.getAnnotation(Description.class).name())
!= 0) {
- return false;
- }
- if (lvFunc.getChildCount() != 2) {
- return false;
- }
Review Comment:
I'm not sure I understand this check. But all lateral views are supported
now, with the exception of OUTER.
This method only checks if CBO can support lateral views. This shouldn't be
a limitation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
