wecharyu commented on PR #4517: URL: https://github.com/apache/hive/pull/4517#issuecomment-1694173723
@deniskuzZ Yes I have checked the sonar reported 2 bugs. > Use try-with-resources or close this "Statement" in a "finally" clause. Actually the related code is inherited from `DirectSqlUpdateStat.java`, and the statement will be closed in the top finally clause. > A "NullPointerException" could be thrown; "table" is nullable here. Since we called `ensureGetTable()`, it will throw `NoSuchObjectException` if not get the table, so the table will never be null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
