abstractdog commented on code in PR #4622: URL: https://github.com/apache/hive/pull/4622#discussion_r1306364579
########## ql/src/test/queries/clientpositive/vector_coalesce.q: ########## @@ -75,3 +75,56 @@ SELECT cbigint, ctinyint, coalesce(cbigint, ctinyint) as c FROM alltypesorc WHERE cbigint IS NULL LIMIT 10; + +create database test; Review Comment: could this test case be further simplified to keep focused on the root cause? 1. is the test failing without the patch? 2. couple of things can be removed as long as the issue is reproduced (please clarify any of these below needed in order to reproduce) a) separate 'test' database b) explicit bucketing INTO 64 BUCKETS c) TBLPROPERTIES: what about removing all of them? I'm pretty sure that orc code is independent of this issue d) what about using MANAGED tables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
