deniskuzZ commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1308768642
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -378,15 +393,21 @@ public void setConf(Configuration conf){
int maxPoolSize = MetastoreConf.getIntVar(conf,
ConfVars.CONNECTION_POOLING_MAX_CONNECTIONS);
synchronized (TxnHandler.class) {
try (DataSourceProvider.DataSourceNameConfigurator configurator =
- new DataSourceProvider.DataSourceNameConfigurator(conf,
"txnhandler")) {
+ new DataSourceProvider.DataSourceNameConfigurator(conf,
POOL_TX)) {
if (connPool == null) {
connPool = setupJdbcConnectionPool(conf, maxPoolSize);
}
if (connPoolMutex == null) {
- configurator.resetName("mutex");
+ configurator.resetName(POOL_MUTEX);
connPoolMutex = setupJdbcConnectionPool(conf, maxPoolSize);
}
}
+ maxPoolSize = MetastoreConf.getIntVar(conf,
ConfVars.HIVE_COMPACTOR_CONNECTION_POOLING_MAX_CONNECTIONS);
+ try (DataSourceProvider.DataSourceNameConfigurator ignored = new
DataSourceProvider.DataSourceNameConfigurator(conf, POOL_COMPACTOR)) {
Review Comment:
are we initiating compaction pool even when CompactionTxnHandler is not
used? CompactionTxnHandler is only used by compaction services, in other cases
it's ThrowingTxnHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
