veghlaci05 commented on code in PR #4384:
URL: https://github.com/apache/hive/pull/4384#discussion_r1309883605
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -2557,7 +2583,7 @@ public void performWriteSetGC() throws MetaException {
}
}
- protected long getMinOpenTxnIdWaterMark(Connection dbConn) throws
MetaException, SQLException {
+ protected long getMinOpenTxnIdWaterMark(Connection dbConn) throws
MetaException {
Review Comment:
getMinOpenTxnIdWaterMark() is called from multiple places and `TxnHandler`
cleanup is not part of this task. I made only the really necessary changes in
it. Since place where this method is called in `TxnHandler` are still not using
`jdbcTemplate`, therefore this method must still accept a `Connection` instance
as parameter. With the cleanup of `TxnHandler` also, the signature can finally
be changed and `jdbcTemplate` used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
