ayushtkn commented on code in PR #4641:
URL: https://github.com/apache/hive/pull/4641#discussion_r1313788415
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/execute/AlterTableExecuteAnalyzer.java:
##########
@@ -124,6 +126,11 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
AlterTableExecuteSpec spec =
new AlterTableExecuteSpec(FAST_FORWARD, new
FastForwardSpec(branchName, targetBranchName));
desc = new AlterTableExecuteDesc(tableName, partitionSpec, spec);
+ } else if (HiveParser.KW_CHERRY_PICK == executeCommandType.getType()) {
+ ASTNode child = (ASTNode) command.getChild(1);
+ long snapshotId = Long.parseLong(child.getText());
+ AlterTableExecuteSpec spec = new AlterTableExecuteSpec(CHERRY_PICK, new
CherryPickSpec(snapshotId));
+ desc = new AlterTableExecuteDesc(tableName, partitionSpec, spec);
Review Comment:
I have refactored the code, give a check if it looks better. happy to modify
even further if you have suggestions :-)
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1400,7 +1405,7 @@ private static boolean
hasParquetNestedTypeWithinListOrMap(Properties tableProps
* Generates {@link JobContext}s for the OutputCommitter for the specific
table.
* @param configuration The configuration used for as a base of the JobConf
* @param tableName The name of the table we are planning to commit
- * @param overwrite If we have to overwrite the existing table or just add
the new data
+ * @param branchName If we have to overwrite the existing table or just add
the new data
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
