sankarh commented on code in PR #4624:
URL: https://github.com/apache/hive/pull/4624#discussion_r1314663355
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java:
##########
@@ -1145,6 +1122,83 @@ public String toString() {
}
}
+ /**
+ * BI strategy is used when the requirement is to spend less time in split
generation
+ * as opposed to query execution (split generation does not read or cache
file footers).
+ */
+ static final class BISplitStrategy extends ACIDSplitStrategy {
Review Comment:
Why did we move the base code around? Hard to review the changes.
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java:
##########
@@ -2875,10 +2875,8 @@ public void testSplitGenReadOpsLocalCache() throws
Exception {
readOpsDelta = statistics.getReadOps() - readOpsBefore;
}
}
- // call-1: listLocatedStatus - mock:/mocktbl
- // call-2: check existence of side file for mock:/mocktbl/0_0
- // call-3: check existence of side file for mock:/mocktbl/0_1
- assertEquals(3, readOpsDelta);
+ // call-1: getAcidState - mock:/mocktbl
Review Comment:
Why is this change? It seems, test is changed to make it work. Any reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
