ngsg commented on code in PR #4115:
URL: https://github.com/apache/hive/pull/4115#discussion_r1316779528
##########
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java:
##########
@@ -221,7 +221,7 @@ public void init(BinaryComparable src) {
fieldBytes = src.getBytes();
int length = src.getLength();
byte nullByte = fieldBytes[0];
- int lastFieldByteEnd = 1, fieldStart = -1, fieldLength = -1;
Review Comment:
fieldStart and fieldLength are not intented to be used as local variable;
they should be set to proper values in init() so that the caller of getShort()
retrieves correct field from the BinaryStruct.
I split the field declaration into separate lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
