nrg4878 commented on code in PR #4569:
URL: https://github.com/apache/hive/pull/4569#discussion_r1307602232
##########
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0-beta-1.derby.sql:
##########
@@ -189,6 +189,8 @@ CREATE TABLE "APP"."NOTIFICATION_LOG" (
CREATE UNIQUE INDEX "APP"."NOTIFICATION_LOG_EVENT_ID" ON
"APP"."NOTIFICATION_LOG" ("EVENT_ID");
+CREATE UNIQUE INDEX "APP"."NOTIFICATION_LOG_UNIQUE_DB" ON
"APP"."NOTIFICATION_LOG" ("DB_NAME", "EVENT_ID");
Review Comment:
We are no longer in beta1. This change needs to go into a different file
##########
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0-beta-1.derby.sql:
##########
@@ -44,6 +44,8 @@ UPDATE "SERDES"
LEFT JOIN "SDS" ON "TBLS"."SD_ID" = "SDS"."SD_ID"
WHERE "TBL_ID" IN (SELECT "TBL_ID" FROM "TABLE_PARAMS" WHERE
"PARAM_VALUE" LIKE '%KuduStorageHandler%')
);
+-- HIVE-27499
Review Comment:
same there, the upgrade file is different now. Please rebase
##########
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0-beta-1.derby.sql:
##########
@@ -189,6 +189,8 @@ CREATE TABLE "APP"."NOTIFICATION_LOG" (
CREATE UNIQUE INDEX "APP"."NOTIFICATION_LOG_EVENT_ID" ON
"APP"."NOTIFICATION_LOG" ("EVENT_ID");
+CREATE UNIQUE INDEX "APP"."NOTIFICATION_LOG_UNIQUE_DB" ON
"APP"."NOTIFICATION_LOG" ("DB_NAME", "EVENT_ID");
Review Comment:
Should the existing index be changed to this or do we still need both these
indices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
